soc: st: stm32: h7rsxx: Fix MPU region for read-only id flash region #99745
Conversation
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
juickar and
mathieuchopstm
I guess we'll need more of those soon, that would be useful. |
it's called IO for a reason |
Do you plan to do it ? |
I can, any suggestions for a good name? |
I'm not sure if this has a lot of value considering that
(i.e., do we really care about the region being read-only?) |
Set correct MPU memory type and size for the uniqe device id, package code and ADC VREF/TS calibration read-only flash region. REGION_IO_ATTR configures the MPU region to device-memory with RW access, which is also used for the PERIPH region. To avoid complicating things unnecessarily, we use this type instead of defining a new device-RO. The size is reduced to 512 bytes, because RM0477 table 28 and chapter 5.3.12 state that this read-only flash area has a size of 512 bytes. Signed-off-by: Thomas Decker <[email protected]>
TD-JBL
force-pushed
the
soc_h7rs_mpu_id_region
branch
from
392c1f4 to
557d1a3
Compare
Good point. Changed the region type to |
|
7 participants
Set correct MPU memory type and size for the uniqe device id, package code and ADC VREF/TS calibration read-only flash region.
(DEVICE_NON_SHAREABLE | REGION_512B | P_RO_U_NA_Msk)) is the same as REGION_IO_ATTR (used for PERIPH region) but RO instead of RW.Edit: REGION_IO_ATTR configures the MPU region to device-memory with RW access, which is also used for the PERIPH region. To avoid complicating things unnecessarily, we use this type instead of defining a new device-RO.
The size is reduced to 512 bytes, because RM0477 table 28 and chapter 5.3.12 state that this read-only flash area has a size of 512 bytes.
I introduced this region with PR #97364, both configurations work, but it is more correct with this one.
Testing: Network still initializes with this changes (reads uniqe device ID for creating the mac address per default).
Cross-check: Will mem-fault during zephyr init when commenting out this
MPU_REGION_ENTRY.Open question: Create a
#definefor this type?REGION_IO_ATTR_ROfor example